New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Line-breaks in Name Table (move this check to googlefonts profile) #2778
Comments
Could you please tell us the check-id of the specific check that is giving you this WARN/FAIL message? I suppose this must be in the |
fontbakery check-universal ... raises errors such as:
|
hmmm... interesting! I think we should move this into the |
oh! It is even worse than that! It is currently on the |
as it is a vendor-specific policy rather than an opentype spec requirement. (issue fonttools#2778)
as it is a vendor-specific policy rather than an opentype spec requirement. (issue #2778)
Done. This change will be included in the upcoming release, FontBakery v0.7.21 which should be published tomorrow during the day. |
Thanks so much for the shockingly fast action on this ... |
:-D |
@ClintGoss, here it is: https://pypi.org/project/fontbakery/0.7.21/ update with Be sure to send further issue reports if you see anything wrong or stuff that could be improved. Glad to see your fine work. You may want to join our FontBakery chat channel at https://gitter.im/fontbakery/Lobby Happy Hacking! |
A test like this could be useful for all the "name" entries (ID 1, 2, 4, 6, 16, 17, 18 ...)? But then check for more control characters. (But maybe there is one already? I only found 'com.google.fonts/check/name/trailing_spaces') |
@schriftgestalt The line_breaks one checks every name entry |
I am still left wondering WHY Google thinks a line break would be unacceptable in the description field, even in their own fonts. |
@tphinney, this is described in the documentation for the check at |
I know. What I meant was to make a new check that only checks those I mentioned. |
please open a new issue describing the proposed new check in detail |
I still don't see the point of this check. There's nothing technically wrong with having line breaks in name records. I agree there shouldn't be line breaks in nameIDs which are related to familyName and subFamilyName though. After reading the check description, I reckon this check was implemented because too many fonts included the full license text? if this was the case, I'd prefer us to just fail name records which include license text or contain too much text. Again failing by length may be too arbitrary. I worry this check will just make designers delete records when they may contain useful information. |
Observed behaviour
Font Bakery complains about name table entries with line-breaks. Could you explain, or point me to, the rationale for this?
Expected behaviour
Line-breaks in the license description field - for example the text of the OFL - seem (to me) to be significant. The OFL without line breaks appears (to me) rather ugly. And might stripping line-breaks possibly change the semantics of the license?
Resources and exact process needed to replicate
The text was updated successfully, but these errors were encountered: