Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Geom #4874

Open
9 tasks done
ThanosPoulakidas opened this issue Jul 3, 2022 · 23 comments
Open
9 tasks done

Add Geom #4874

ThanosPoulakidas opened this issue Jul 3, 2022 · 23 comments
Labels
-- Needs design work I New Font II Submission pending proposal for non-commissioned fonts suggested in the issue tracker

Comments

@ThanosPoulakidas
Copy link

ThanosPoulakidas commented Jul 3, 2022

Font Project Git Repo URL:
https://github.com/ThanosPoulakidas/Geom.git

Previous Issue URL:
#4525

Super short description of the Font Family:
Geom, is a contemporary geometric sans serif typeface. It has 7 weights. This typeface is intended for display purposes but it works just as well in small texts. Even though the geometric typefaces look more dynamic in relation with other typefaces, Geom has gone one step further by having an even more additional dynamic characteristics on some of its characters. The typeface is a variable font which includes a Latin and Greek character set.

Requirements:

I understand that Google Fonts will publish only fonts that matches its requirements, and I can confirm the project meets them (by ticking the cases, or putting x between the square brackets in text mode):

  • The entire font project is licensed under the OFL
  • There is no "Reserved Font Name" mention in the OFL license
  • Family name is unique according to namecheck.fontdata.com
  • The font supports at least GF Latin Core glyphset
  • The repository respect the upstream repo structure
  • The source files are available in the repository
  • I read, agree and comply with the full contributing requirements
  • I am the author of the font or the author agreed to this submission
  • I will maintain the repository

Image:

Attach here a pic or a screenshot of the font; one is enough, it can be few letters, to give a quick overview.

@ThanosPoulakidas ThanosPoulakidas added I New Font II Submission pending proposal for non-commissioned fonts suggested in the issue tracker labels Jul 3, 2022
@tphinney
Copy link
Collaborator

For some reason the “fonts” folder is in the “sources” folder. That’s not quite right, it should be in the main directory. (Both to avoid confusion and for submission to Google.)

Also, the Regular weight is named “Rergular” for both the OTF and TTF files.

@ThanosPoulakidas
Copy link
Author

@tphinney Thanks for the input. I changed the location of the "fonts" folder.
As for "the Regular weight is named “Rergular” for both the OTF and TTF files" should the Regular weight to be just the name of the typeface's name?

@tphinney
Copy link
Collaborator

tphinney commented Jul 26, 2022

That gets complicated, but I think Google’s standard is to include the style name in there.

(Technically the OpenType spec does not require it, and some Adobe fonts have omitted it in the past, but I for one have always thought that was a bit odd. IIRC, they mostly only did that in their earliest fonts up to around 1990 or so, and mostly when the font was a single-member family.)

I was just pointing out that “Regular” was spelled incorrectly, with an extra “r”

@ThanosPoulakidas
Copy link
Author

Now I get it. I never saw the extra "r". Thanks!

@ThanosPoulakidas
Copy link
Author

@RosaWagner What exactly does the label "Needs design work" ?

@davelab6
Copy link
Member

davelab6 commented Oct 2, 2022

@RosaWagner What exactly does the label "Needs design work" ?

More of what was previously described here

#4525 (comment)

https://github.com/ThanosPoulakidas/Geom/tree/main/sources has more than one glyphs source file which is strange, and the style names in the extraneous file names don't match our requirements.

@ThanosPoulakidas
Copy link
Author

I think it should be ok now?

@ThanosPoulakidas
Copy link
Author

Each time an error in the Build Font Phase keeps appearing. 186
Can you help me with that?

@tphinney
Copy link
Collaborator

I should leave this to the folks who know GF Builder, which I don’t use yet.
But I note the first failure is this:
“ERROR:GFBuilder:Could not build variable font: In 'Geom-Light[wght].glyphs': Loading Glyphs file failed: Missing ';' on line 582”

So that suggests a problem in the Glyphs file, or at least in GF Builder being able to parse it. Probably need to post (or point to) that Glyphs file for help.

@ThanosPoulakidas
Copy link
Author

I checked the Glyphs and there was a problem with 7 glyphs during the export on the variable format and I corrected it but the same problem appears again.

@ThanosPoulakidas
Copy link
Author

Hi,
Is it possible to help me pinpoint the parts that need help in improving it for the upload?

@davelab6
Copy link
Member

davelab6 commented Mar 3, 2023

@felipesanches I suggest you could schedule a time for a call with @ThanosPoulakidas to better understand the need of users here

@ThanosPoulakidas
Copy link
Author

@felipesanches I wiil be waiting for your invitation

@ThanosPoulakidas
Copy link
Author

The problem I am facing this moment, is there a possibility to be similar to this?

@ThanosPoulakidas
Copy link
Author

@simoncozens I have just reuplaoded the files

@simoncozens
Copy link
Collaborator

Great, thank you! Yes, the problem here is that you are using quadratic curves and the overlap removal step is failing. You could convert all your curves to cubic using the Path > Other > Convert to Cubic menu option in glyphs, or if you really want to design with quadratics, you can add the item:

removeOutlineOverlaps: false

in your source/config.yaml.

@ThanosPoulakidas
Copy link
Author

@simoncozens
I just addeed the item:

removeOutlineOverlaps: false
in your source/config.yaml.

But does the way I placed it makes a difference?

@simoncozens
Copy link
Collaborator

Let me work on it and send you a PR.

@ThanosPoulakidas
Copy link
Author

How do I install the latest FontBakery?

@tphinney
Copy link
Collaborator

Install info is at: https://font-bakery.readthedocs.io/en/latest/

You can also run it online via a web site at http://fontbakery.com/ — it runs locally in your web browser and does not upload the font(s) or anything. (BUT the web browser version can’t run all the possible tests. It does do most of them, however!)

@ThanosPoulakidas
Copy link
Author

First of all, thanks for the links.
But I am still struggling to make it work.

@ThanosPoulakidas
Copy link
Author

Do I have to update the fontbakery? Because I am checking other repositories which they also have older versions of the fontbakery

@ThanosPoulakidas ThanosPoulakidas mentioned this issue Jan 24, 2024
9 tasks
@ThanosPoulakidas
Copy link
Author

Is there something else that I need to work on?

@davelab6 davelab6 added this to the Submissions to review milestone Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-- Needs design work I New Font II Submission pending proposal for non-commissioned fonts suggested in the issue tracker
Projects
None yet
Development

No branches or pull requests

6 participants