Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Geom #4525

Closed
9 tasks done
ThanosPoulakidas opened this issue Apr 17, 2022 · 13 comments
Closed
9 tasks done

Add Geom #4525

ThanosPoulakidas opened this issue Apr 17, 2022 · 13 comments
Labels
I New Font II Submission pending proposal for non-commissioned fonts suggested in the issue tracker

Comments

@ThanosPoulakidas
Copy link

ThanosPoulakidas commented Apr 17, 2022

Font Project Git Repo URL:
https://github.com/ThanosPoulakidas/Geom.git

Super short description of the Font Family:
Geom, is a contemporary geometric sans serif typeface. It has 7 weights. This typeface is intended for display purposes but it works just as well in small texts. Even though the geometric typefaces look more dynamic in relation with other typefaces, Geom has gone one step further by having an even more additional dynamic characteristics on some of its characters. The typeface is a variable font which includes a Latin and Greek character set.

Requirements:

I understand that Google Fonts will publish only fonts that matches its requirements, and I can confirm the project meets them (by ticking the cases, or putting x between the square brackets in text mode):

  • The entire font project is licensed under the OFL
  • There is no "Reserved Font Name" mention in the OFL license
  • Family name is unique according to namecheck.fontdata.com
  • The font supports at least GF Latin Core glyphset
  • The repository respect the upstream repo structure
  • The source files are available in the repository
  • I read, agree and comply with the full contributing requirements
  • I am the author of the font or the author agreed to this submission
  • I will maintain the repository
@ThanosPoulakidas ThanosPoulakidas added I New Font II Submission pending proposal for non-commissioned fonts suggested in the issue tracker labels Apr 17, 2022
@RosaWagner
Copy link
Contributor

please @ThanosPoulakidas ping us for review when you have added font binaries to the repo + update readme.md with description and images adapted to your project :)

@RosaWagner RosaWagner added the -- Needs Upstream Resolution Upstream fix required before moving forward label Apr 22, 2022
@RosaWagner RosaWagner mentioned this issue May 12, 2022
9 tasks
@ThanosPoulakidas
Copy link
Author

Thank you @RosaWagner for the answer!
The readme.md has been updated, but as for the font binaries I would like to ask what exactly are those files.
Are you actually reffering to font file formats such as ttf?

Thanks again for your time! :)

@davelab6
Copy link
Member

davelab6 commented May 12, 2022

@ThanosPoulakidas yes exactly, we'd like you to move the subfolders in sources to be within a new top level folder, fonts

Also it seems your Github Actions aren't yet running (https://github.com/ThanosPoulakidas/Geom/actions/runs/2315937559) and I appreciate you may not be able to resolve that yourself. @RosaWagner or someone will be able to take a look :)

@ThanosPoulakidas
Copy link
Author

Hi @davelab6. The font files have already been added. However, whenever I create a folder named fonts and move the files inside it in the sources folder, these files seem to disappear. The github app doesn't seem to find them, like they are invinsible or something.

@RosaWagner
Copy link
Contributor

remove "font" from .gitignore

@ThanosPoulakidas
Copy link
Author

I removed it from .gitignore and now the file has been uploaded successfully.
Still the problem with build font step remains.

@ThanosPoulakidas
Copy link
Author

@RosaWagner Do you know what is wrong with the build action?
The message's error is: "fontmake.errors.FontmakeError: In 'Geom-Light.glyphs': Loading Glyphs file failed: Junk after plist at line 34869".
But I can't seem to understand what exactly is the error.
Any tip that could help, I would appreciate it!

@RosaWagner RosaWagner added this to the Important projects to be commissioned and milestoned milestone May 19, 2022
@RosaWagner
Copy link
Contributor

@ThanosPoulakidas we took your submission into account, and we will take a look when we will have time to do so :) meanwhile, you can look at other repo such as Texturina, Radio Canada, JetBrains etc. or ask for help to Fontmake if there is an issue with fontmake.

@ThanosPoulakidas
Copy link
Author

Thank you for your answer! I will look the things you mentioned!

@RosaWagner RosaWagner added -- Needs manager's opinion from upper level and removed -- Needs Upstream Resolution Upstream fix required before moving forward labels Jun 23, 2022
@RosaWagner RosaWagner removed this from the Important projects to be commissioned and milestoned milestone Jun 23, 2022
@RosaWagner RosaWagner removed the -- Needs manager's opinion from upper level label Jun 24, 2022
@RosaWagner
Copy link
Contributor

RosaWagner commented Jun 24, 2022

Hello Thanos, we finally got the time to review the family.

We think that is a great start, the typeface has personality and we liked the pointy serif. Unfortunately, it doesn't match technical and design expectations yet. We really encourage you to keep up with the good work, and in the following I'll give you points where you can improve and also related links:

  • Glyphset is not covering GF Latin Core, and I also suggest you to check out the GF Glyphset for Greek with the links and recommendations from Irene Vlachou in the Readme.md. You may know all of that already but it also might come as an interest, who knows :)
  • Diacritics are suffering from bad positioning, and there is a confusion between legacy and combining accents. I recommend you read the diacritic chapter of our documentation, as well as the other useful links suggested at the end of it.
  • I spotted some spacing and kerning issues. I would recommend to erase all kerning, develop your font, and then try again with a methodical approach.
  • It looks like the file were Fontlab5 converted to Glyphs, and they kept the quadratic curves. Unfortunately, fontmake can't build fonts with quadratic curves yet, they need to convert to Cubic (in GlyphsApp: Path>Other>Convert to Cubic). It will also be easier for you to correct some curves this way. We have a chapter about outlines if you want to more about the technicalities of the subject.
  • For building the font and other GF specificities, I recommend to get familiar with the entire Documentation, and in particular these chapters: Font file requirements, VF specificities, Building the Font.

You can also learn more about type design on this amazing website: https://typedesignschool.com

Don't hesitate to re-open an submission issue when you think the font is ready again ;)

@ThanosPoulakidas
Copy link
Author

@RosaWagner
Thank you for your answer!
I have made changes and uploaded the new files.
As for the GF Glyphset for Greek, the polytonic system is not something that fits well with the idea of this typeface. In addition to that there are other fonts that are uploaded withouth having the polytonic greek system or any other system except for the basic system. If you think that by adding them, I will increase the chances or the need of having, I would gladly do it.
As for all the variable part of the font, I am still reading on that part.
Nevertheless, I uploaded the new files for the time being.

@ThanosPoulakidas ThanosPoulakidas mentioned this issue Jul 3, 2022
9 tasks
@thlinard
Copy link
Contributor

thlinard commented Jul 8, 2022

As for the GF Glyphset for Greek, the polytonic system is not something that fits well with the idea of this typeface.

@ThanosPoulakidas Hi, you read the specs too hastily: GF Glyphset for Greek is also about monotonic Greek.

@ThanosPoulakidas
Copy link
Author

@thlinard You were right.
I uploaded the new files with the right GF Glyphset for Greek for monotonic Greek.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I New Font II Submission pending proposal for non-commissioned fonts suggested in the issue tracker
Projects
None yet
Development

No branches or pull requests

4 participants