Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spacing axis #9

Merged
merged 4 commits into from Nov 27, 2017
Merged

Spacing axis #9

merged 4 commits into from Nov 27, 2017

Conversation

LetterModeller
Copy link
Contributor

No description provided.

@msftclas
Copy link

msftclas commented Nov 23, 2017

CLA assistant check
All CLA requirements met.

@justvanrossum
Copy link

Additional application idea:

  • make ligatures properly respond to spacing

Perhaps also mention latin-based connected script typefaces.

@tiroj
Copy link
Collaborator

tiroj commented Nov 23, 2017

I am interpreting this proposal as for 'optical spacing', i.e. it isn't simply an x-direction 'white space' adjustment feature (although could be implemented as such), but may also involve adjustments to glyph shape (indeed, may require such adjustments in the case of joining scripts), and may involve variable GPOS interaction, e.g. to scale kerning proportionally to variable spacing. @LetterModeller does that interpretation fit with what you have in mind.

[I think that for all new axis proposals we need to understand whether the proposed axis is optical or parametric (perhaps this is a category to add to the standard proposal template?). I define an optical axis as one that may affect more than one aspect of a design at a time, e.g. stem weight changing on a width axis; whereas a parametric axis affects only one aspect at a time, independently of others (cf. Amstelvar). These represent two different models of designing a variable font, and it seems fairly important to distinguish whether a given axis proposal is optical or parametric. All five of the initially registered OT variations axes are optical axes, although only one — Optical Size — explicitly acknowledges this.]

Copy link

@PeterCon PeterCon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposal summary is incomplete: it is missing the Administrative and General Technical Information sections, which should precede the Proposed Axis Details section.

Also, the heading for the Justification section is missing. Please keep all of the sections, with headings, in the order given in the template ProposalSummary.md file

Copy link

@PeterCon PeterCon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format needs fixing but details are all there. I'll approve and fix the formatting afterward.

@PeterCon PeterCon merged commit ef1eeaa into microsoft:master Nov 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants