Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make outline width a theme option #1082

Closed
davelab6 opened this issue Jan 4, 2014 · 5 comments
Closed

Make outline width a theme option #1082

davelab6 opened this issue Jan 4, 2014 · 5 comments
Labels

Comments

@davelab6
Copy link
Member

davelab6 commented Jan 4, 2014

Currently the outline of the spline is 1px. It would be great to have this as a theme variable, but drawn in such a way that a say 5px line gets thicker INSIDE the shape, not on both sides, so that increasing the value doesn't distort the apparent shape.

This is in response to a request on a type design forum

@monkeyiq
Copy link
Contributor

monkeyiq commented Jan 5, 2014

Interesting... To draw 5px INSIDE then it seems I have to copy the splineset and move each point 2.5px inside the old shape. I'll have a further experiment tomorrow. Currently trying to move x/y and then determine if that point is INSIDE the shape. The INSIDE test is done using a ray from the new point and counting even/odd collisions with the splines in the splineset. (odd for rays in each direction == inside of shape).

But its not moving the points uniformly yet.

@davelab6
Copy link
Member Author

davelab6 commented Jan 5, 2014

Doesn't Cairo have a method to paint inside an area?

@monkeyiq
Copy link
Contributor

monkeyiq commented Jan 6, 2014

See Preferences / Editing / OutlineThickness (set > 1 to have effect, eg 5).
Colour is from X Resource Editor / Outline View 2 / Active Thick Layer Color (default is grey with alpha so you can still see the normal outline also to verify things are as expected).

Setting outlinethickness needs a forced redraw to have effect, eg, by left clicking on the charview.

@vernnobile
Copy link
Contributor

Nice. I've set the outline to 2, and then set the colours of 'Active Thick Layer Color' and 'Active Layer Color' to be identical (mid gray). Functions well imo.
fforge12

@davelab6
Copy link
Member Author

cc @pathumego

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants
@davelab6 @monkeyiq @vernnobile and others